Skip to content

document component vol7 #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 2, 2021
Merged

document component vol7 #239

merged 6 commits into from
Feb 2, 2021

Conversation

youchann
Copy link
Contributor

@youchann youchann commented Jan 29, 2021

やったやつ

  • <Divider />
  • <DataTable />

@youchann youchann requested a review from a team as a code owner January 29, 2021 08:43

## Samples

### Basic
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

props多すぎるので、まだまだ表現の幅あるが、一旦これぐらいにしておく

@@ -144,19 +144,65 @@ type Tab<T> = {
};

export type DataTableProps<T> = {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

結構英語書いたけど不安アリ

@youchann youchann requested a review from ryokosuge January 29, 2021 09:39
Copy link
Contributor

@ryokosuge ryokosuge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@youchann youchann merged commit edf8c10 into master Feb 2, 2021
@youchann youchann deleted the add-document-component-7 branch February 2, 2021 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants